Comments

• ChrisIceBox

  August 2025 edited August 2025

  Can you share screenshots to illustrate the issue? Share shots of the issue as it occurs in the game, as well as the Menus / ActionLists involved.

  I'll also need details on how you're handling the "highlight last item" feature.
• Saturnine

  August 2025 edited August 2025

  Hi Chris, thanks for the reply, here are the shots of the inventory menu, how I add the item, and the screenshot in game. In the shot, I just picked up a rock, I hear it add to the inventory but as it is at the end off to the right I can't see it add, then if I go up to the inventory and use the arrow to scroll right when the rock comes into view it then hilights! I would like to continue adding picked up items to the end though as the journal and map should always be first. I'm not sure what the 'hilight last item' feature is, so that's probably my problem! (AC version is v1.60.4)
  https://ibb.co/Ngj5BQ8p
  https://ibb.co/4RwcNd5N
  https://ibb.co/TDb3xMVC
• ChrisIceBox

  August 2025

  (AC version is v1.60.4)

  Egads, that's 8 years old!

  To shift to the end, you'd need to run the following code line:

  AC.PlayerMenus.GetElementWithName ("Inventory", "InventoryBox").Shift(AC.AC_ShiftInventory.ShiftNext, 100);
  

  Create a new C# script named FullyShiftInventory.cs and copy/paste:

  using UnityEngine;
  public class FullyShiftInventory : MonoBehaviour
  {
      public void Shift()
      {
          AC.PlayerMenus.GetElementWithName("Inventory", "InventoryBox").Shift(AC.AC_ShiftInventory.ShiftNext, 100);
      }
  }
  

  Add to an Empty GameObject, make it a prefab, and then use the Object: Call event Action to run the prefab's Shift function, just after the Menu: Change state Action that turns the Menu on.
• Saturnine

  August 2025

  Perfect! That works great, thank you Chris! Ha, yeah 8 years old, I'm far too scared to update now!
• Saturnine

  December 2025

  Hi Chris, I'm sorry but this isn't working now, I swear it did when I first tried it but after making sure that I am 'carrying on start' the exact amount of inventory items to fill the on screen space, collecting something else doesn't shift the inventory to the end and show the new item, there is a warning on the action that says 'Parameters passed from here cannot be set, unfortunately, due to a Unity limitation' maybe it never worked and I somehow thought it did, sorry about that Chris, hopefully it can be edited to work? Action list image: https://ibb.co/ymzcbKq7
• ChrisIceBox

  December 2025

  The warning can be ignored here because the function doesn't include any parameters.

  We can try placing in a Debug.Log statement to confirm that it's being run by checking the console. Place this inside the Shift function:

  Debug.Log ("Shifted inventory to end");
  

  However, I'd expect you'd need to run this event after the Inventory: Add or remove Action, as the effect isn't permanent. Once you add a new item, the Inventory will again go beyond the current offset.
• Saturnine

  January 1

  Thanks Chris, that was it, I was opening the inventory, shifting it and then adding the item, changed it to shift after adding the item, all working great now, thanks again!
• Saturnine

  January 17

  Hi Chris, sorry to bring this up yet again, but I have an error, I had been testing the shift inventory script by purposely filling up the inventory (10 slots in my case) so the next item would have to shift the inventory, then picking up a new item with the shift script on it just to test that it works, which it does and I thought that was all working, but after removing the extra inventory items again so that a new one just adds to the end on screen without the need to shift, it gives an error, sorry about this but I don't understand a word of it

  ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
  Parameter name: index
  System.ThrowHelper.ThrowArgumentOutOfRangeException (System.ExceptionArgument argument, System.ExceptionResource resource) (at :0)
  System.ThrowHelper.ThrowArgumentOutOfRangeException () (at :0)
  AC.MenuInventoryBox.Display (UnityEngine.GUIStyle _style, System.Int32 _slot, System.Single zoom, System.Boolean isActive) (at Assets/AdventureCreator/Scripts/Menu/Menu classes/MenuInventoryBox.cs:587)
  AC.PlayerMenus.DrawMenu (AC.Menu menu, System.Int32 languageNumber) (at Assets/AdventureCreator/Scripts/Controls/PlayerMenus.cs:561)
  AC.PlayerMenus.DrawMenus () (at Assets/AdventureCreator/Scripts/Controls/PlayerMenus.cs:396)
  AC.StateHandler._OnGUI () (at Assets/AdventureCreator/Scripts/Game engine/StateHandler.cs:614)
  AC.StateHandler.OnGUI () (at Assets/AdventureCreator/Scripts/Game engine/StateHandler.cs:546)
  UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)

  It still works as expected whether it needs to shift or not, but if it doesn't need to it gives a red error in the console
• ChrisIceBox

  January 18

  If this is still from AC v1.60, It's very likely a bug that's since been fixed.

  Can you share a screenshot of the offending line - and code surrounding it? It's referring to line 587 of the MenuInventoryBox script.
• Saturnine

  January 21 edited January 22

  Hi Chris, I'm not sure how much of the surrounding code is relevant, so here is a link to the whole script:

  [REMOVED]
• ChrisIceBox

  January 22

  Please don't share the full script - this is still AC's source code.

  Oddly, the line endings don't appear to match exactly but try replacing:

  if (items.Count > 0 && items.Count > (_slot+offset) && items [_slot+offset] != null)
  

  with:

  if (items.Count > 0 && (_slot+offset) >= 0 && items.Count > (_slot+offset) && items [_slot+offset] != null)
  
• Saturnine

  January 24

  Hey Chris, very sorry about that! I changed the line in the script and it shifts the whole inventory over leaving blank spaces athe the left, then when it closes again and I open the inventory normally everything is back to normal. I don't know what I'm doing here at all and I think I will just try and find out the max number of inventory items can be carried at any one time in the game and rescale the inventory box to accomodate that max number. Thanks for checking it out though.