Comments

• tis_I_jb

  October 2024

  A Little More Testing

  1. It appears that if no Action List operates on the images, they are able to be displayed. I did try deleting the problematic objects in the ObjectivesUI prefab and recreating them from scratch, however I get the same results. I have added screen shots that show some objects displaying graphics, and some not. The ones that lose their images are the same ones that that are operated on by the Action List.
  2. I also added a screen shot of the Action List.
  3. Attempting a work-around, I deleted the image and instead created a material that uses the same image file as a texture. In doing it that way, there are two interesting results:
     • The material seems to "stick" when the prefab is instantiated during game play testing, where the image would not.
     • While the material version of the graphic is visible, it is only barely so, and its color has been changed from the image's original color to red. This was true using both a red and a green version of the image.

  Screenshots link > https://imgur.com/a/adventure-creator-objectives-ui-not-linking-game-play-mode-unity-l5iPYcf
• ChrisIceBox

  October 2024

  It looks like this is a case of the Graphic correctly linking - as AC is affecting the assigned Image.

  The issue is that there is no texture assigned in the Graphic element's "Texture" field. At runtime, AC will apply this texture to the Image component - even if that texture is null.

  It's a good case for the opposite behaviour, however: if no texture is assigned here, then AC should probably just leave the assigned Image alone and instead just control its visibility.

  You can get this behaviour by opening AC's MenuGraphic script and replacing its SetUIGraphic function (around line 447) with the following:

  private void SetUIGraphic ()
  {
      if (!Application.isPlaying) return;
  
      if (uiImageType == UIImageType.Image && uiImage)
      {
          Sprite sprite = null;
          switch (graphicType)
          {
              case AC_GraphicType.Normal:
                  sprite = graphic.GetAnimatedSprite (true);
                  break;
  
              case AC_GraphicType.DialoguePortrait:
                  if (speech != null && portraitCharacterOverride == null)
                  {
                      sprite = speech.GetPortraitSprite ();
                  }
                  else if (portraitCharacterOverride != null)
                  {
                      sprite = portraitCharacterOverride.GetPortraitSprite ();
                  }
                  if (sprite == null && graphic != null && graphic.texture)
                  {
                      sprite = graphic.GetAnimatedSprite (true);
                  }
                  break;
  
              case AC_GraphicType.DocumentTexture:
              case AC_GraphicType.ObjectiveTexture:
              case AC_GraphicType.PageTexture:
                  sprite = sprite;
                  if (sprite == null && graphic != null && graphic.texture)
                  {
                      sprite = graphic.GetAnimatedSprite (true);
                  }
                  break;
  
              default:
                  break;
          }
          if (sprite) uiImage.sprite = sprite;
          UpdateUIElement (uiImage);
      }
      if (uiImageType == UIImageType.RawImage && uiRawImage)
      {
          switch (graphicType)
          {
              case AC_GraphicType.Normal:
                  if (graphic.texture && graphic.texture is RenderTexture)
                  {
                      uiRawImage.texture = graphic.texture;
                  }
                  else
                  {
                      uiRawImage.texture = graphic.GetAnimatedTexture (true);
                  }
                  break;
  
              case AC_GraphicType.DocumentTexture:
              case AC_GraphicType.ObjectiveTexture:
              case AC_GraphicType.DialoguePortrait:
              case AC_GraphicType.PageTexture:
                  uiRawImage.texture = localTexture;
                  if (localTexture == null && graphic.texture)
                  {
                      if (uiRawImage.texture && graphic.texture is RenderTexture)
                      {
                          uiRawImage.texture = graphic.texture;
                      }
                      else
                      {
                          uiRawImage.texture = graphic.GetAnimatedTexture (true);
                      }
                  }
                  break;
          }
  
          UpdateUIElement (uiRawImage);
      }
  }
  

  Does that give the intended behaviour?
• tis_I_jb

  October 2024

  LOL, I'm banging my head on the desk now.

  Of course! It makes perfect sense to interpret the Texture field in the AC Game Editor to mean "use this texture to display in your new menu element." It makes so much more sense to assign the appropriate texture there than to try to embed one in the ObjectsUI prefab.

  I wasn't sure what that texture slot was for. The existing Selected Texture element on the menu didn't use one so I was ignoring this one, but now I think I see how you intend it to work.

  That ^^ fixes the issue I was having. Thank you for that!

  Thanks also for providing the suggested code. In order to provide a test for that for you, I opened the MenuGraphic.cs file and commented out the existing SetUIGraphic function, and instead pasted in the code you provided above.

  I'm not able to test it any further than that, however. It gives two compile errors in the Unity console, as it recognizes neither the argument uiImage nor uiRawImage.

  If I were to suggest a change for future versions of AC, I would suggest adding a tool tip in the AC Game Editor > Menu > Graphic (new) > Texture heading.

  Something to the effect of "assign a texture here to display in the menu element."

  Updated Images > https://imgur.com/a/adventure-creator-objectives-ui-not-linking-game-play-mode-unity-l5iPYcf

  Thanks again, Chris. Here's hoping your week is excellent!
• ChrisIceBox

  October 2024

  What's the exact compilation error that appears in the Console?

  Either way, I'll make the adjustment in the next release.
• tis_I_jb

  October 2024

  I'm getting the following two errors (one for each line number):

  [path]\MenuGraphic.cs(line number,9): error CS7036: There is no argument given that corresponds to the required formal parameter 'uiComponentHideStyle' of 'MenuElement.UpdateUIElement(T, UIComponentHideStyle)'
• ChrisIceBox

  October 2024

  Replace the two problematic lines with:

  UpdateUIElement (uiImage, uiComponentHideStyle);
  UpdateUIElement (uiRawImage, uiComponentHideStyle);